Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding Discord Markdown badge #3539

Merged
merged 2 commits into from
Nov 12, 2024
Merged

feat: Adding Discord Markdown badge #3539

merged 2 commits into from
Nov 12, 2024

Conversation

yhakbar
Copy link
Collaborator

@yhakbar yhakbar commented Nov 8, 2024 •
edited
Loading

Description

Makes a badge on the README.md that users can click to join the discord.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Updated README.md.

@yhakbar
Copy link
Collaborator Author

yhakbar commented Nov 8, 2024

Seems like the API managing badges is rate limited right now. Will wait for it to render correctly before marking ready for review.

@yhakbar yhakbar marked this pull request as ready for review November 11, 2024 17:57
@yhakbar
Copy link
Collaborator Author

yhakbar commented Nov 11, 2024

The API reset, so this is ready to go now.

denis256
denis256 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@denis256 denis256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@yhakbar yhakbar merged commit 6839411 into main Nov 12, 2024
4 of 5 checks passed
@yhakbar yhakbar deleted the chore/adding-discord-invite-badge branch November 12, 2024 20:36
@BrewTestBot BrewTestBot mentioned this pull request Nov 13, 2024
Merged
4 tasks
@renovate renovate bot mentioned this pull request Nov 19, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis256 denis256 denis256 approved these changes

@levkohimins levkohimins Awaiting requested review from levkohimins levkohimins is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhakbar @denis256