Skip to content
This repository has been archived by the owner on Mar 29, 2023. It is now read-only.

Add module http-load-balancer-website #4

Merged
merged 11 commits into from
Mar 25, 2019
Merged

Add module http-load-balancer-website #4

merged 11 commits into from
Mar 25, 2019

Conversation

autero1
Copy link
Contributor

@autero1 autero1 commented Mar 22, 2019

This PR adds a module that deploys a HTTP Load Balancer that routes requests to a Google Cloud Storage bucket for static content hosting.

Internally the module uses the terraform-google-load-balancer http-load-balancer -module.

Copy link
Contributor

@robmorgan robmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor things

examples/http-load-balancer-website/README.md Outdated Show resolved Hide resolved
examples/http-load-balancer-website/README.md Outdated Show resolved Hide resolved
examples/http-load-balancer-website/main.tf Outdated Show resolved Hide resolved
Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A few minor suggestion to docs, but nothing substantial or critical.

modules/http-load-balancer-website/README.md Outdated Show resolved Hide resolved
modules/http-load-balancer-website/README.md Outdated Show resolved Hide resolved
test/test_util.go Show resolved Hide resolved
@autero1 autero1 requested a review from robmorgan March 25, 2019 13:45
@@ -19,7 +19,7 @@ provider "google-beta" {
module "static_site" {
# When using these modules in your own templates, you will need to use a Git URL with a ref attribute that pins you
# to a specific version of the modules, such as the following example:
# source = "git::[email protected]:gruntwork-io/terraform-google-static-assets.git//modules/cloud-load-balancer-website?ref=v0.1.0"
# source = "git::[email protected]:gruntwork-io/terraform-google-static-assets.git//modules/http-load-balancer-website?ref=v0.1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool 👍

@@ -94,6 +94,7 @@ variable "access_log_prefix" {
default = ""
}

# TODO: KMS FIX
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@autero1 autero1 merged commit 4430e9b into master Mar 25, 2019
@autero1 autero1 deleted the clb-site branch March 25, 2019 15:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants