Skip to content
This repository has been archived by the owner on Mar 29, 2023. It is now read-only.

Update repo to work with Terraform 0.13.x #12

Merged
merged 9 commits into from
Dec 14, 2020
Merged

Update repo to work with Terraform 0.13.x #12

merged 9 commits into from
Dec 14, 2020

Conversation

robmorgan
Copy link
Contributor

@robmorgan robmorgan commented Nov 12, 2020

  1. Update CircleCI to use Terraform 0.13.x.
  2. Update the version constraint on all examples to require at least Terraform 0.12.26.
  3. Update pre-commit hooks to add gofmt.
  4. Drop Go Dep in favor of Go modules.
  5. Upgrade the tests to support Terratest v0.30.23

In general, TF 0.13.x seems backwards compatible from a testing perspective: I did not need to change anything in modules in this PR. I've also ensured the modules and examples work with Google Provider 3.x.

@robmorgan
Copy link
Contributor Author

Waiting for an admin to re-enable the CircleCI tests.

@robmorgan
Copy link
Contributor Author

Ok that's done, this PR is now ready for review!

@rhoboat rhoboat self-requested a review December 11, 2020 15:41
Copy link
Contributor

@rhoboat rhoboat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I checked the CI yaml and everything else looks good, too.

@robmorgan
Copy link
Contributor Author

thanks @rhoboat !

@robmorgan robmorgan merged commit f0147d4 into master Dec 14, 2020
@robmorgan robmorgan deleted the tf13 branch December 14, 2020 08:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants