Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite collections package as generic functions #79

Merged
merged 5 commits into from
Nov 11, 2022
Merged

Rewrite collections package as generic functions #79

merged 5 commits into from
Nov 11, 2022

Conversation

infraredgirl
Copy link
Contributor

@infraredgirl infraredgirl commented Nov 8, 2022 •
edited
Loading

This also bumps the Go version to 1.18.

Note that this would be a backwards incompatible change due to Go v1.18 now being required.

Unfortunately there's a failing test that I haven't had time to resolve. Solved: tests are now passing.

@infraredgirl infraredgirl self-assigned this Nov 8, 2022
brikis98
brikis98 previously approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Love the new tests too 👍

brikis98
brikis98 reviewed Nov 8, 2022
View reviewed changes
Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, one thought: I see you're using ~. Perhaps we should add some tests that use not only raw types (e.g., int) but custom type definitions (e.g., type Foo int) to ensure the ~ is having the intended effect?

@infraredgirl
Copy link
Contributor Author

Ok, tests are now passing, and I added a test case to verify that using a custom type works.

This is ready for a final review.

brikis98
brikis98 approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@infraredgirl
Copy link
Contributor Author

Thanks, will merge and release.

@infraredgirl infraredgirl merged commit 9082ced into master Nov 11, 2022
@infraredgirl infraredgirl deleted the collections-generics branch November 11, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brikis98 brikis98 brikis98 approved these changes

@ellisonc ellisonc Awaiting requested review from ellisonc

@arsci arsci Awaiting requested review from arsci arsci is a code owner

@zackproser zackproser Awaiting requested review from zackproser

@pete0emerson pete0emerson Awaiting requested review from pete0emerson

@james03160927 james03160927 Awaiting requested review from james03160927

Assignees

@infraredgirl infraredgirl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@infraredgirl @brikis98