Ensure all Route53HostedZones are deleted by adding pagination support #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbocinec
changed the title
sbocinec
changed the title
wakeful
reviewed
Dec 17, 2024
aws/resources/route53_hostedzone.go
Outdated
| logging.Errorf("[Failed] unable to list resource record set: %s", err) | ||
| return err | ||
| } | ||
| for { |
There was a problem hiding this comment.
Wouldn’t using NewListResourceRecordSetsPaginator be easier? You could then use HasMorePages() as an iterator for the loop, e.q. example from docs
There was a problem hiding this comment.
Great idea! I have updated the PR
sbocinec
force-pushed
the
route53-hosted-zone-pagination
branch
from
4562e37 to
3a987d4
Compare
wakeful
reviewed
Dec 19, 2024
aws/resources/route53_hostedzone.go
Outdated
| marker *string | ||
| ) | ||
|
|
||
| for { |
There was a problem hiding this comment.
This one could also use a paginator NewListHostedZonesPaginator
There was a problem hiding this comment.
I have already updated the PR.
Add pagination support to list/nuke all hosted zones as the list response is truncated when there many hosted zones exist.
sbocinec
force-pushed
the
route53-hosted-zone-pagination
branch
from
3a987d4 to
5e875b9
Compare
james03160927
approved these changes
Dec 20, 2024
|
Passed all the tests. Good to merge the change now. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add pagination support for Route53HostedZones resource to list and delete all existing resources. Currently, the list operation did only a single request so it was only able to delete 100 HostedZones/Records (default max number of the element returned by the
ListHostedZone/ListResourceRecordSetsAPI calls.Ref: https://github.com/aws/aws-sdk-go-v2/blob/service/route53/v1.46.3/service/route53/api_op_ListHostedZones.go#L38-L63
Fixes #817.
TODOs
Read the Gruntwork contribution guidelines.
nuke_sandboxandnuke_phxdevopsjobs in.circleci/config.ymlhave been updated with appropriate exclusions (either directly in the job or via the.circleci/nuke_config.ymlfile) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.Release Notes (draft)
Add Route53HostedZones pagination support to list & delete all hosted zones [X].
Migration Guide