Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change port route53 cidr collection, route53 hostedzone, route53 traffic policy to awsSDKv2 #770 #796

Merged

Conversation

wakeful
Copy link
Contributor

@wakeful wakeful commented Nov 21, 2024

Description

Fixes #770 port route53 resources to awsSDKv2

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Updated route53 CIDR collection, route53 hosted zone, route53 traffic policy

Migration Guide

n/a

@wakeful wakeful force-pushed the migrate-to-aws-sdk-v2-part-8 branch from c314fd7 to ba8d1ee Compare November 25, 2024 08:38
Copy link
Contributor

@james03160927 james03160927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@james03160927 james03160927 merged commit a01c723 into gruntwork-io:master Nov 25, 2024
2 checks passed
@wakeful wakeful deleted the migrate-to-aws-sdk-v2-part-8 branch November 26, 2024 06:34
sbocinec added a commit to sbocinec/cloud-nuke that referenced this pull request Dec 17, 2024
The bug introduced in migration to awsSDKv2 gruntwork-io#796
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to AWS SDKv2
2 participants