Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for elastic-cache serverless & grafana resources. #784

Conversation

wakeful
Copy link
Contributor

@wakeful wakeful commented Nov 11, 2024

Description

added support for elastic-cache server-less & grafana resources.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

  • Added elastic-cache server-less & grafana resources.

Migration Guide

n/a

james03160927
james03160927 previously approved these changes Nov 12, 2024
Copy link
Contributor

@james03160927 james03160927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the change LGTM. Probably need rebase.

@wakeful wakeful force-pushed the add-grafana-and-serverless-elasticache-resources branch from 7a5bdf8 to 535631e Compare November 12, 2024 06:35
@wakeful
Copy link
Contributor Author

wakeful commented Nov 12, 2024

rebase done

Copy link
Contributor

@james03160927 james03160927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@james03160927 james03160927 merged commit 4bc68db into gruntwork-io:master Nov 14, 2024
2 checks passed
@wakeful wakeful deleted the add-grafana-and-serverless-elasticache-resources branch November 27, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants