Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #782 elasticache crash on address or nil pointer dereference in case we have a single node cluster. #783

Conversation

wakeful
Copy link
Contributor

@wakeful wakeful commented Nov 11, 2024

Description

running nuke on single node elasticache cluster fails with address or nil pointer dereference

Fixes #782

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

[x] Fixes #782 single node elasticache cluster fails with address or nil pointer dereference

Migration Guide

n/a

…eference` in case we have a single node cluster.
Copy link
Contributor

@james03160927 james03160927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@james03160927 james03160927 merged commit b0cd4b0 into gruntwork-io:master Nov 12, 2024
2 checks passed
@wakeful wakeful deleted the fix-782-elasticache-nil-when-accessing-replicationGroupOutput branch November 12, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

elasticache nuke error
2 participants