Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to aws sdk v2 part 1 #772

Merged

Conversation

wakeful
Copy link
Contributor

@wakeful wakeful commented Oct 20, 2024

Description

port the below resources to AWS SDKv2 (part of work for #770

  • APIGWv1
  • APIGWv2
  • ASG
  • access_analyzer
  • acm
  • acmpca
  • ami
  • appRunner
  • backupvault
  • cloudTrail
  • cloudWatchalarm
  • cloudWatchdashboard
  • cloudWatchlogGroup
  • codeDeployApplication
  • configrecorder
  • configservice
  • dataSynclocation
  • dataSynctask
  • dynamodb

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Updated APIGWv1, APIGWv2, ASG, access_analyzer, acm, acmpca, ami, appRunner, backupvault, cloudTrail, cloudWatchalarm, cloudWatchdashboard, cloudWatchlogGroup, codeDeployApplication, configrecorder, configservice, dataSynclocation, dataSynctask, dynamodb to AWS SDK v2.

Migration Guide

n/a

@james03160927 james03160927 self-assigned this Oct 22, 2024
@james03160927
Copy link
Contributor

Triggered tests for this change.

@wakeful wakeful force-pushed the migrate-to-aws-sdk-v2-part-1 branch from cdd1430 to 2ade8f5 Compare October 26, 2024 20:21
@wakeful
Copy link
Contributor Author

wakeful commented Oct 26, 2024

rebase to remove conflicts.

@james03160927
Copy link
Contributor

Nice. LGTM.

Copy link
Contributor

@james03160927 james03160927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@james03160927 james03160927 merged commit 0730c0a into gruntwork-io:master Oct 28, 2024
2 checks passed
@wakeful wakeful deleted the migrate-to-aws-sdk-v2-part-1 branch November 3, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants