Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: added support for china region #766

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

james03160927
Copy link
Contributor

Description

Fixes #126

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

aws/region.go Outdated Show resolved Hide resolved
@james03160927 james03160927 force-pushed the feature/support-china-regions branch 2 times, most recently from 6fef31f to 5717db6 Compare August 30, 2024 02:10
@denis256
Copy link
Member

Looks like changes are failing to compile

# github.com/gruntwork-io/cloud-nuke/aws/resources
aws/resources/ec2_placement_group.go:32:16: configObj.EC2PlacementGroups undefined (type config.Config has no field or method EC2PlacementGroups)
aws/resources/ec2_placement_group_types.go:41:19: configObj.EC2PlacementGroups undefined (type config.Config has no field or method EC2PlacementGroups)

@wakeful
Copy link
Contributor

wakeful commented Aug 30, 2024

Rebasing should fix the problem

$ go build .
# github.com/gruntwork-io/cloud-nuke/aws/resources
aws/resources/ec2_placement_group.go:32:16: configObj.EC2PlacementGroups undefined (type config.Config has no field or method EC2PlacementGroups)
aws/resources/ec2_placement_group_types.go:41:19: configObj.EC2PlacementGroups undefined (type config.Config has no field or method EC2PlacementGroups)

$ git log feature/support-china-regions..master --oneline
4d997c4 (upstream/master, origin/master, origin/HEAD, master) fix: iam user exclude not working (#764)
0c6e8ba (tag: v0.37.2) add aws v2 sdk to support newer resources (#745) (#746)
45e4ac8 Fix config rule nuking (#762)
9f56e5a fix: nuke failure when route53 record NS exists with subdomain (#759)
c818032 Fix merge conflict issue (#761)

$ git rebase master
Successfully rebased and updated refs/heads/feature/support-china-regions.

$ go build .

$ echo $?
0

@james03160927 james03160927 force-pushed the feature/support-china-regions branch from 5717db6 to c3f93ae Compare August 30, 2024 23:07
@james03160927
Copy link
Contributor Author

Rebased again. Should be good now.

@james03160927 james03160927 merged commit 3a951dd into master Sep 5, 2024
3 checks passed
@james03160927 james03160927 deleted the feature/support-china-regions branch September 5, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not support cn-north-1, cn-northwest-1 region
4 participants