Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for nuking dataSync Task(s) & dataSync Location(s). #729

Merged

Conversation

wakeful
Copy link
Contributor

@wakeful wakeful commented Jun 23, 2024

Description

Fixes #000.

add support for cleaning up AWS DataSync resources.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Added support for nuking DataSync Task(s) & DataSync Location(s).

@wakeful wakeful requested review from arsci and denis256 as code owners June 23, 2024 12:09
@james03160927
Copy link
Contributor

Thanks for the contribution. Will kick off the test pipeline for this change.

@james03160927
Copy link
Contributor

Passing all the tests. Merging the change.

Copy link
Contributor

@james03160927 james03160927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@james03160927 james03160927 merged commit a96a10f into gruntwork-io:master Jun 26, 2024
2 checks passed
@wakeful wakeful deleted the feature/add-support-for-datasync branch September 25, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants