add support for nuking app runner service(s). #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,6 +22,7 @@ type Config struct { | |||
| APIGatewayV2 ResourceType `yaml:"APIGatewayV2"` | |||
| AccessAnalyzer ResourceType `yaml:"AccessAnalyzer"` | |||
| AutoScalingGroup ResourceType `yaml:"AutoScalingGroup"` | |||
| AppRunnerService ResourceType `yaml:"AppRunnerService"` | |||
There was a problem hiding this comment.
You probably need to update the config_test.go file to pass the unit test.
There was a problem hiding this comment.
actually you right - but seem like that test is also failing on master for me :| will fix it today
There was a problem hiding this comment.
sorted, but I needed to add field names to the test file, this way it should be easier to maintain when new fields will be added.
wakeful
force-pushed
the
feature/add-support-for-app-runner
branch
from
170c7ff to
921582c
Compare
|
Triggered the test pipeline. Also manually tested in locally. Seems to be working fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #000.
add support for cleaning up App Runner Services
TODOs
Read the Gruntwork contribution guidelines.
nuke_sandboxandnuke_phxdevopsjobs in.circleci/config.ymlhave been updated with appropriate exclusions (either directly in the job or via the.circleci/nuke_config.ymlfile) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.Release Notes (draft)
Added support for nuking
app runner service(s).Migration Guide