Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle parsing of timestamps in time.DateTime format. Fix #670 #678

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

sbocinec
Copy link
Contributor

@sbocinec sbocinec commented Apr 12, 2024

Description

Handle parsing of timestamps in time.DateTime format. Fixes #670

cloud-nuke (v0.35.0) is currently unable to parse EIPs (and possibly other resources) that are tagged with cloud-nuke-first-seen containing non-RFC3339 timestamp as you can see here:
image

This leads to the EIP not being deleted due to the following error:

 ERROR   Unable to retrieve eip, parsing time "2023-12-19 10:34:26" as "2006-01-02T15:04:05Z07:00": cannot parse " 10:34:26" as "T"

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Fixed parsing of FirstSeenTag in non-RFC3339 format to fix EIP nuke

Migration Guide

Copy link
Contributor

@james03160927 james03160927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let me trigger the test pipeline

Copy link
Contributor

@james03160927 james03160927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@james03160927 james03160927 merged commit 0e54514 into gruntwork-io:master Apr 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EIP timestamp parsing error
2 participants