Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SME-256 S3 deletion #674

Merged
merged 2 commits into from
Apr 8, 2024
Merged

SME-256 S3 deletion #674

merged 2 commits into from
Apr 8, 2024

Conversation

autero1
Copy link
Contributor

@autero1 autero1 commented Apr 8, 2024

Description

Fixes #659.

  • As bucket versioning is managed separately and you can turn off versioning after the bucket is created, we need to check if there are any versions in the bucket regardless of the versioning status.

  • Restore EIP deletion in PHXDevOps

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

@autero1
Copy link
Contributor Author

autero1 commented Apr 8, 2024

Tested with a bucket that has versioning turned off after uploading files.

This is before change:

image

And this is after the change:

image

Copy link
Contributor

@james03160927 james03160927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@autero1 autero1 merged commit c5f5552 into master Apr 8, 2024
3 checks passed
@autero1 autero1 deleted the SME-256/s3-deletion branch April 8, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with S3 deletion
2 participants