Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

condition to allow multi region list only to us-west-2 #671

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

james03160927
Copy link
Contributor

Description

Fixes #667.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

denis256
denis256 previously approved these changes Apr 4, 2024
@james03160927 james03160927 force-pushed the 50/multi-region-ap-listing branch 2 times, most recently from 070fab4 to 0b6a0af Compare April 5, 2024 00:37
@james03160927
Copy link
Contributor Author

Hey @denis256, can I get an additional approval on this PR? Had to rebase.

denis256
denis256 previously approved these changes Apr 5, 2024
@james03160927 james03160927 force-pushed the 50/multi-region-ap-listing branch from 8ce03f4 to f186424 Compare April 8, 2024 13:12
@james03160927 james03160927 merged commit e77f8ff into master Apr 8, 2024
3 checks passed
@james03160927 james03160927 deleted the 50/multi-region-ap-listing branch April 8, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure to Delete Access Point
2 participants