Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing Timeout Feature on S3 #653

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

james03160927
Copy link
Contributor

Description

Fixes #417

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

aws/aws.go Outdated Show resolved Hide resolved
@denis256
Copy link
Member

Looks like go mod tidy wasn't executed:

$ git status
On branch 23-timing-out-nuke-through-cli
Your branch is up-to-date with 'origin/23-timing-out-nuke-through-cli'.

nothing to commit, working tree clean
$ go mod tidy
$ git status
On branch 23-timing-out-nuke-through-cli
Your branch is up-to-date with 'origin/23-timing-out-nuke-through-cli'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   go.mod

no changes added to commit (use "git add" and/or "git commit -a")

util/error.go Outdated Show resolved Hide resolved
util/error.go Outdated Show resolved Hide resolved
@james03160927 james03160927 merged commit 70b23f0 into master Mar 25, 2024
3 checks passed
@james03160927 james03160927 deleted the 23-timing-out-nuke-through-cli branch March 25, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timing out nuke through cli
2 participants