s3 access point support #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis256
reviewed
Mar 12, 2024
| accountID, ok := c.Value(util.AccountIdKey).(string) | ||
| if !ok { | ||
| logging.Errorf("unable to read the account-id from context") | ||
| return nil, errors.WithStackTrace(fmt.Errorf("unable to lookup the account id")) |
There was a problem hiding this comment.
I was wondering why should be defined dynamic errors and not dedicated struct errors like https://github.com/gruntwork-io/cloud-nuke/blob/master/aws/resources/ec2.go#L621
There was a problem hiding this comment.
Hey @denis256, I'm not too sure what's the benefit of declaring a dedicated error struct in this scenario. Potential benefit would be using this error code to test things more thoroughly in unit tests -- we are not actually doing that and just checking whether certain scenario produce an error or not.
Do you have other benefits you have in mind?
There was a problem hiding this comment.
Yes, it is mostly to have more robust error checking
denis256
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #442
TODOs
Read the Gruntwork contribution guidelines.
nuke_sandboxandnuke_phxdevopsjobs in.circleci/config.ymlhave been updated with appropriate exclusions (either directly in the job or via the.circleci/nuke_config.ymlfile) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.Release Notes (draft)
Added / Removed / Updated [X].
Migration Guide