elastic bean stalk application implementation #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis256
approved these changes
Feb 27, 2024
denis256
reviewed
Feb 27, 2024
| // get the deleted ids | ||
| deletedApps = append(deletedApps, id) | ||
| logging.Debugf("Deleted Elastic Beanstalk application: %s", *id) | ||
|
|
There was a problem hiding this comment.
aws/resources/elastic_beanstalk.go:67: unnecessary trailing newline (whitespace)
}
There was a problem hiding this comment.
will reformat later!
denis256
reviewed
Feb 27, 2024
| } | ||
|
|
||
| for name, tc := range tests { | ||
| t.Run(name, func(t *testing.T) { |
There was a problem hiding this comment.
Was wondering why not to use t.Parallel()
There was a problem hiding this comment.
We should be able to use that. All the tests are mocked so it's pretty fast so no need to parallelized for performance at this point but we can definitely enable parallelism on all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #351.
TODOs
Read the Gruntwork contribution guidelines.
nuke_sandboxandnuke_phxdevopsjobs in.circleci/config.ymlhave been updated with appropriate exclusions (either directly in the job or via the.circleci/nuke_config.ymlfile) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.Release Notes (draft)
Added / Removed / Updated [X].
Migration Guide