Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup CI #6

Merged
merged 4 commits into from
Feb 9, 2018
Merged

Setup CI #6

merged 4 commits into from
Feb 9, 2018

Conversation

tonerdo
Copy link
Contributor

@tonerdo tonerdo commented Feb 9, 2018

No description provided.

Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Just one minor tweak to the build command!

circle.yml Outdated
- checkout
- attach_workspace:
at: /go/src/github.com/gruntwork-io/aws-nuke
- run: build-go-binaries --circle-ci-2 --app-name aws-nuke --dest-path bin --ld-flags "-X main.VERSION=$CIRCLE_TAG -extldflags '-static'"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure you need the -extldflags '-static' portion at the end.

@brikis98
Copy link
Member

brikis98 commented Feb 9, 2018

Woohoo! Merging :)

@brikis98 brikis98 merged commit f06752f into master Feb 9, 2018
@brikis98
Copy link
Member

brikis98 commented Feb 9, 2018

@tonerdo Assuming the build on master passes, create a v0.0.1 release, and let's see if the binaries upload properly too!

@tonerdo tonerdo deleted the setup-ci branch February 22, 2018 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants