Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement functionality to include/exclude resources by tags #570

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

james03160927
Copy link
Contributor

@james03160927 james03160927 commented Aug 25, 2023

Description

Capability to include/exclude resource types based on tags

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

@zachreborn
Copy link

The code all looks good to me, but this could really use a new addition to the readme to show a few examples of the new API functionality.

@james03160927
Copy link
Contributor Author

The code all looks good to me, but this could really use a new addition to the readme to show a few examples of the new API functionality.

Realized there's quite a lot of content to update so raised a separate PR for this - #571.

@james03160927 james03160927 merged commit 6b41a50 into master Aug 28, 2023
@james03160927 james03160927 deleted the tag_exclusion branch August 28, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants