Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log-level not working properly #568

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Fix log-level not working properly #568

merged 2 commits into from
Aug 29, 2023

Conversation

james03160927
Copy link
Contributor

Description

Partially fix #552 issue about logging problem.
Testing: verified debug level is set properly and working properly.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Added / Removed / Updated [X].

Updated [Fix log-level not working properly]

Migration Guide

zachreborn
zachreborn previously approved these changes Aug 25, 2023
@james03160927 james03160927 merged commit 6887713 into master Aug 29, 2023
@james03160927 james03160927 deleted the logging branch August 29, 2023 22:34
@james03160927 james03160927 restored the logging branch September 7, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloud-nuke s3 fails deleting buckets that are not empty
2 participants