Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Eip #545

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Refactor Eip #545

merged 2 commits into from
Aug 9, 2023

Conversation

james03160927
Copy link
Contributor

Description

Part of #494.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Added / Removed / Updated [X].

Updated [Refactor Eip]

Updated [refactor elastic cache]

Migration Guide

MoonMoon1919
MoonMoon1919 reviewed Aug 7, 2023
View reviewed changes
util/time.go Outdated Show resolved Hide resolved
MoonMoon1919
MoonMoon1919 reviewed Aug 7, 2023
View reviewed changes
Copy link
Contributor

@MoonMoon1919 MoonMoon1919 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, see comment. Otherwise good work!

@james03160927 james03160927 merged commit bbaa2b7 into master Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoonMoon1919 MoonMoon1919 MoonMoon1919 approved these changes

@arsci arsci Awaiting requested review from arsci arsci is a code owner

@denis256 denis256 Awaiting requested review from denis256 denis256 is a code owner

@ellisonc ellisonc Awaiting requested review from ellisonc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@james03160927 @MoonMoon1919