Refactor SQS Resource Type #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachreborn
suggested changes
Jul 26, 2023
| func getAllSqsQueue(session *session.Session, region string, excludeAfter time.Time) ([]*string, error) { | ||
| svc := sqs.New(session) | ||
|
|
||
| func (sq SqsQueue) getAll(configObj config.Config) ([]*string, error) { |
There was a problem hiding this comment.
I have what might be a nitpick here, the shortening of SQS Queue to sq instead of sqs. I get why, because it's similar to your other shorthand naming conventions but this one feels a bit too short for one letter difference. Thoughts?
There was a problem hiding this comment.
One caveat is it conflicts with the import of aws sqs library. I agree that it's more readable if we name is sqs but just to avoid conflicts with the import, sq might work better here.
zachreborn
approved these changes
Jul 26, 2023
flichtenheld
added a commit
to flichtenheld/cloud-nuke
that referenced
this pull request
Nov 7, 2023
This was broken by PR gruntwork-io#517. SQS uses Unix timestamps, so we need to make sure to treat them as such. Signed-off-by: Frank Lichtenheld <[email protected]>
james03160927
pushed a commit
that referenced
this pull request
Nov 12, 2023
This was broken by PR #517. SQS uses Unix timestamps, so we need to make sure to treat them as such. Signed-off-by: Frank Lichtenheld <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #494.
TODOs
Read the Gruntwork contribution guidelines.
nuke_sandboxandnuke_phxdevopsjobs in.circleci/config.ymlhave been updated with appropriate exclusions (either directly in the job or via the.circleci/nuke_config.ymlfile) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.Release Notes (draft)
Added / Removed / Updated [X].
Updated [Refactor SQS Resource Type]
Migration Guide