Refactor CodeDeploy, ConfigRecorder, ConfigServiceRule resource types #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachreborn
suggested changes
Jul 26, 2023
| func getAllCodeDeployApplications(session *session.Session, excludeAfter time.Time, configObj config.Config) ([]string, error) { | ||
| svc := codedeploy.New(session) | ||
|
|
||
| func (c CodeDeployApplications) getAll(configObj config.Config) ([]*string, error) { |
There was a problem hiding this comment.
Same shorthand conversation here, perhaps cda? I feel like single letter abbreviations, while being golang cannon, make a some things more difficult:
- Find & Replace
- Regex searches
- Function walking
- Refactoring
There was a problem hiding this comment.
Ah definitely, In order to prevent back-and-forth approval again, I'll go through consistency related changes at once after all refactoring since it would be quite easy to make!
zachreborn
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #494.
TODOs
Read the Gruntwork contribution guidelines.
nuke_sandboxandnuke_phxdevopsjobs in.circleci/config.ymlhave been updated with appropriate exclusions (either directly in the job or via the.circleci/nuke_config.ymlfile) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.Release Notes (draft)
Added / Removed / Updated [X].
Updated [Refactor CodeDeploy, ConfigRecorder, ConfigServiceRule resource types]
Migration Guide