Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize aws Client in ResourceType #509

Merged
merged 3 commits into from
Jul 21, 2023
Merged

Conversation

james03160927
Copy link
Contributor

@james03160927 james03160927 commented Jul 20, 2023

Description

Part of #494.
Initialize aws Client in ResourceType
This should be no-op change.

A bit more context. I was thinking of refactoring one by one but noticed a lot of merge conflicts one after the other. Making all changes that could resolve merge conflicts in the future!

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • [] Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Added / Removed / Updated [X].

Updated [Initialize aws Client in ResourceType]

Migration Guide

@james03160927 james03160927 force-pushed the refactor_all_attempt2 branch from c39bab4 to b81f3c0 Compare July 20, 2023 20:03
@james03160927 james03160927 merged commit 1b6398c into master Jul 21, 2023
@james03160927 james03160927 deleted the refactor_all_attempt2 branch July 21, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants