Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support nuking EC2 Dedicated Hosts - CORE-286 #392

Merged
merged 3 commits into from
Jan 5, 2023
Merged

Support nuking EC2 Dedicated Hosts - CORE-286 #392

merged 3 commits into from
Jan 5, 2023

Conversation

arsci
Copy link
Contributor

@arsci arsci commented Jan 4, 2023 •
edited
Loading

Description

Closes CORE-286

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes

Add support for nuking EC2 Dedicated Hosts

denis256
denis256 reviewed Jan 4, 2023
View reviewed changes
aws/ec2_dedicated_host.go Outdated Show resolved Hide resolved
denis256
denis256 previously approved these changes Jan 4, 2023
View reviewed changes
pete0emerson
pete0emerson approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@pete0emerson pete0emerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arsci arsci merged commit bbcded7 into master Jan 5, 2023
@zackproser zackproser deleted the feature/add-support-ec2-dedicated-hosts/CORE-286 branch January 22, 2023 13:05
@denis256 denis256 mentioned this pull request Feb 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pete0emerson pete0emerson pete0emerson approved these changes

@denis256 denis256 denis256 left review comments

@zackproser zackproser Awaiting requested review from zackproser

@ellisonc ellisonc Awaiting requested review from ellisonc

@james03160927 james03160927 Awaiting requested review from james03160927

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arsci @pete0emerson @denis256