-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add kinesis stream support #304
feat: add kinesis stream support #304
Conversation
My apologies, I've just had a closer look at the diff and it seems that when I saved in my IDE |
} | ||
} | ||
|
||
func assertKinesisStreamsDeleted(t *testing.T, svc *kinesis.Kinesis, identifiers []*string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function assertKinesisStreamsDeleted
is not invoked in any other place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good catch! Added the missing calls 👍
90bae70
to
34406db
Compare
34406db
to
d378526
Compare
@denis256 👋 Just checking in to see if you've had a chance to look at this yet? 😄 |
Hi, |
Failed tests:
|
d378526
to
d9b6ae7
Compare
@denis256 My bad, small logic error. Should be good to go now. |
Hi,
|
d9b6ae7
to
79da0e6
Compare
@denis256 Conflicts have been fixed 👍 |
79da0e6
to
830be22
Compare
@denis256 Sorry to keep nagging but do you think this is good to go now? 😅 |
830be22
to
74cdf73
Compare
Looks like after merge build is failing:
|
74cdf73
to
be3f5bb
Compare
Fixed 👍 |
Hi,
|
Resolved 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI job passed without failures, going to merge into master
Description
This pull request adds support for nuking Kinesis Stream as mentioned in #301. I'll bring in Kinesis Firehose support in another pull request when I get a bit more time.
I pretty much just translated the work done in this pull request and applied it to Kinesis Streams so please let me know if anything is incorrect style/logic wise 😄
Tests in the
kinesis_stream_test.go
are passing as well as when you run the CLI withgo run main.go aws --resource-type kinesis-stream
.Docs have been updated to show the Kinesis Stream support.
Because this is adding support for a new resource this pull request will introduce breaking changes as per here