Add support for deleting Auto Scaling Groups. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that an ASG cannot be deleted until it contains 0 instances, so we first set the desired capacity down to 0, then wait, then delete the ASG. Also fixed a bug where we were attempting to terminate EC2 Instances that were already terminated.
brikis98
reviewed
Jan 13, 2018
|
|
||
| # Deleting ASGs after we nuke everything else is a hacky way to give set_asgs_num_desired_instances_to_zero enough | ||
| # time to complete its actions. We sleep an additional 10 seconds before proceeding just to be sure. | ||
| sleep 10 |
There was a problem hiding this comment.
There's no way this will be enough. ASGs can easily take 2-5 min to empty out.
|
We've moved to Go, and this functionality is now part of #5, so closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that an ASG cannot be deleted until it contains 0 instances, so we first set the desired capacity down to 0, then wait, then delete the ASG.
Also fixed a bug where we were attempting to terminate EC2 Instances that were already terminated.