Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudwatch Log Group Nuking #289

Merged
merged 5 commits into from
Mar 11, 2022
Merged

Cloudwatch Log Group Nuking #289

merged 5 commits into from
Mar 11, 2022

Conversation

yorinasub17
Copy link
Contributor

This is an extension of #250, with the following fixes:

  • Resolve merge conflict
  • Add nuke config for our environments
  • Add support for filtering by name, specified via config file
  • Add support for filtering by creation time
  • Make delete call concurrently in batches
  • Support paging through list of cloudwatch log groups, instead of just getting the first page

denis256
denis256 previously approved these changes Mar 11, 2022
"github.com/hashicorp/go-multierror"
)

func getAllCloudWatchLogGroups(session *session.Session, region string, excludeAfter time.Time, configObj config.Config) ([]*string, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

region - variable unused now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah you are right! Removed: cebb784

@yorinasub17
Copy link
Contributor Author

Thanks for review! Merging this in now!

@yorinasub17 yorinasub17 merged commit 745a0b2 into master Mar 11, 2022
@yorinasub17 yorinasub17 deleted the cloudwatch branch March 11, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants