support deleting vpcs that are non-default #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekristen
requested review from
ina-stoyanova,
infraredgirl,
marinalimeira and
robmorgan
as code owners
bwhaley
reviewed
Nov 16, 2021
There was a problem hiding this comment.
Changes LGTM!
One request: could you please add VPCs to the list of resources in the README, and also add a subsection under Usage that explains that that default VPCs are excluded when nuking VPCs? I agree with you that excluding them makes sense since we have a dedicated defaults-aws command for that. Also, nuking the default VPCs would break some internal use cases we have. But we ought to explain our reasoning in the docs.
Thanks!
|
@bwhaley changes made as requested. |
bwhaley
reviewed
Nov 16, 2021
Co-authored-by: Ben Whaley <[email protected]>
|
Thanks @bwhaley I've got a number of other PRs open ;-) -- I'll make sure to update the README on each one too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes the existing VPC code and implements it for non-default per region nuking.