Nuke EKS compute resources #234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yorinasub17
requested review from
ina-stoyanova,
infraredgirl,
marinalimeira and
robmorgan
as code owners
|
Ran this in PHX and here is the output: |
Merged
brikis98
approved these changes
Nov 16, 2021
Comment on lines
+149
to
+153
| // We can't delete Fargate profiles in parallel, so we delete them sequentially, waiting until the profile has been | ||
| // deleted before moving on to the next one. This will make the delete routine very slow, but unfortunately, there | ||
| // is no other alternative. | ||
| // See https://docs.aws.amazon.com/eks/latest/APIReference/API_DeleteFargateProfile.html for more info on the serial | ||
| // requirement. |
|
Thanks for review! Merged as a part of #238 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #111 and #148
In my monthly AWS bill investigation, I keep having to manually nuke EKS clusters with clickops in our accounts that have Fargate Profiles or Node Groups and I don't want to do that anymore. This PR updates the EKS nuke routine to clean up those compute resources so that the EKS cluster can be nuked.
Note that in order to do so, I had to bump the AWS SDK version, which in turn meant that the mocks needed to be refreshed. That's where the changes to
aws/mocks/EC2API.gois coming from.