Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add potential support other cloud providers #22

Merged
merged 5 commits into from
Mar 20, 2018
Merged

Conversation

tonerdo
Copy link
Contributor

@tonerdo tonerdo commented Mar 20, 2018

No description provided.

@tonerdo tonerdo changed the title Support other cloud providers Add potential support other cloud providers Mar 20, 2018
Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one minor tweak.

commands/cli.go Outdated
}
}

return UnsupportedProviderError{}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are no args, you should prob just show the help text (urfave/cli has some method to do that).

@tonerdo tonerdo merged commit 20a5384 into master Mar 20, 2018
@tonerdo tonerdo deleted the support-other-clouds branch April 10, 2018 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants