Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex formatting from nuke_config.yml #216

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Conversation

marinalimeira
Copy link
Contributor

Build is current broken with the following error:

❯ houston exec phxops -- go run main.go aws \
  --older-than 1h \
  --force \
  --config ./.circleci/nuke_config.yml \
  --exclude-resource-type iam
ERROR: Error reading config - ./.circleci/nuke_config.yml - yaml: unmarshal errors:
  line 1: cannot unmarshal !!seq into string
exit status 1
ERROR: ErrorWithExitCode{ Err = exit status 1, ExitCode = 1 }

Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Verified it works.

@yorinasub17
Copy link
Contributor

Merging in so we start nuking our account again!

@yorinasub17 yorinasub17 merged commit 45346e0 into master Oct 12, 2021
@infraredgirl
Copy link
Contributor

Why was this not caught in the original PR? Do we need to add a regression test?

@yorinasub17
Copy link
Contributor

yorinasub17 commented Oct 12, 2021

We don't have a unit test that sanity checks our own internal circleci nuke config, and the nuke job only runs on trunk. I think adding a regression test that confirms it's parseable makes sense!

@infraredgirl
Copy link
Contributor

Great, I added an issue for this ⬆️.

@marinalimeira
Copy link
Contributor Author

Thank you for creating the issue, Ana!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants