Nuke User owned AMIs #18
Conversation
| } | ||
|
|
||
| _, err := svc.DeregisterImage(params) | ||
| if err != nil { |
There was a problem hiding this comment.
If you try to delete an AMI that's actively in use, do you get an error? If so, we should catch it, log it, and keep going.
There was a problem hiding this comment.
From my tests an AMI can be deleted even when there exists an EC2 instance that was created with it. I believe once the VM is provisioned with that machine image there's no link between them and that ami exists just for re-provisioning new EC2 instances
There was a problem hiding this comment.
Sweet, I'll merge once I fix the test
There was a problem hiding this comment.
@tonerdo Is deleting an AMI actually a two-step procedure as I had to do in ec2-snapper? At that time, I first had to deregister the AMI (as you do here), and second, had to delete the AMI's corresponding EBS snapshot.
|
|
||
| func createTestAMI(t *testing.T, session *session.Session, name string) ec2.Image { | ||
| svc := ec2.New(session) | ||
| instance := createTestEC2Instance(t, session, name, false) |
There was a problem hiding this comment.
Should this defer the deletion of this instance?
There was a problem hiding this comment.
It does the defer on line 62. If the defer is done here, the EC2 instance could have been nuked before we get a chance to create the Image. The safest bet is to just clean up after the test function itself
This PR does the following: