Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved text file identification to handle json files #169

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

denis256
Copy link
Member

@denis256 denis256 commented Mar 8, 2024

Description

Included changes:

  • updated text file identification to handle JSON files
  • added integration tests to track that variables in JSON files are replaced

Fixes #168.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Updated JSON file processing to substitute placeholder variables.

Migration Guide

@denis256 denis256 marked this pull request as ready for review March 8, 2024 21:35
Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@denis256 denis256 merged commit 441f030 into master Mar 8, 2024
3 checks passed
@denis256 denis256 deleted the bug/json-text-168 branch March 8, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot produce quoted JSON
2 participants