-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boilerplate windows support #164
Conversation
This is the announcement blog post I was talking about: https://blog.gruntwork.io/introducing-boilerplate-6d796444ecf6. It contains links to the boilerplate repo, but I made the links go to a specific commit, so if you make changes to the example code, it shouldn't break anything. We really do need the dynamic name in the test file (hence the |
Fixed tests for Windows and updated approach with variables in file names - in git are stored "generic" names and in tests for "unix" platform files are renamed with variables in the name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Please merge and release.
Description
Included changes:
Before this change:
With the change from this PR:
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added / Removed / Updated [X].
Updated boilerplate template path identification in Windows.
Migration Guide