Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boilerplate windows support #164

Merged
merged 54 commits into from
Mar 5, 2024
Merged

Boilerplate windows support #164

merged 54 commits into from
Mar 5, 2024

Conversation

denis256
Copy link
Member

@denis256 denis256 commented Mar 4, 2024

Description

Included changes:

  • Fixed handling of paths in Windows
  • Added support for Windows CICD
  • Fixed base tests for Windows environment
  • Changed "kebab test" to generate files with placeholder instead of saving files in git since it breaks repo clone in Windows
  • Added skipping for some tests that relay on OS native commands
  • Updated mime type detection to use only read data

Before this change:

Screenshot 2024-03-04 at 20 48 49

With the change from this PR:

Screenshot 2024-03-04 at 20 46 25

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Updated boilerplate template path identification in Windows.

Migration Guide

@denis256 denis256 changed the title Template path transformation Boilerplate windows support Mar 5, 2024
@denis256 denis256 marked this pull request as ready for review March 5, 2024 12:36
@brikis98
Copy link
Member

brikis98 commented Mar 5, 2024

This is the announcement blog post I was talking about: https://blog.gruntwork.io/introducing-boilerplate-6d796444ecf6. It contains links to the boilerplate repo, but I made the links go to a specific commit, so if you make changes to the example code, it shouldn't break anything. We really do need the dynamic name in the test file (hence the {{ xxx }} in the path), but fixing all the issues on Windows is pretty important, so perhaps for now, you can update that example to dynamically generate the file, so we can get this merged soon, and we can come back to a more long-term fix in the future?

@denis256
Copy link
Member Author

denis256 commented Mar 5, 2024

Fixed tests for Windows and updated approach with variables in file names - in git are stored "generic" names and in tests for "unix" platform files are renamed with variables in the name

https://github.com/gruntwork-io/boilerplate/pull/164/files#diff-029441898e3ff4247efb42bd1056bce6b2b51b6a8950731f9b94c71ff93ae364R78

Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please merge and release.

@denis256 denis256 merged commit 7973e52 into master Mar 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants