-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuring .npmignore #65
Comments
That's probably a good idea. Personally, I like having all that extra in npm modules so that I can debug more easily when necessary, but I doubt that's a common use. |
Definitely, but we should rather use the https://npmjs.org/doc/json.html#files Huge 👍 from me though. |
Ok, let's do that ^. @CaryLandholt let me know if you have any interest in doing this otherwise I'll write a script and take care of this soon. Thanks! |
Just for clarification, let's include: {
"files": [
"tasks/",
"AUTHORS",
"CHANGELOG",
"CONTRIBUTING.md",
"LICENSE-MIT",
"package.json",
"README.md"
]
} |
no need for AUTHORS, CHANGELOG, CONTRIBUTING.md in the package. And package.json and readme.md is always included, so no need to specify. |
Cool, did not know that... so that makes it really simple: {
"files": [
"tasks",
"LICENSE-MIT"
]
} EDIT: Removed the |
yup, you can drop the |
The deed is done. |
Hah, nice. Thanks @shama |
Yay! |
…merge-from-upstream * 'master' of github.com:gruntjs/grunt-contrib-qunit: (29 commits) Update copyright to 2014 Style and Doc Fixes Squashed commit of the following: 0.4.0 Update grunt-lib-phantomjs to v0.5.0. Explicitly set files to publish to npm. Ref gruntjs/gruntjs.com#65 Update qunit-overview.md, include CentOS dependencies. Closes asciidiscogh-49 0.3.0 Fixes asciidiscoGH-47. Update to latest phantom dependency. Remove Gruntfile.js as main in package.json removing confusing error message Propagate error.onError events from Phantom. Closes asciidiscoGH-11. Update README Update readme to document PhantomJS OS dependencies. Fixes asciidisco#43 Revert "Cleanup trailing whitespace in docs". Necessary for hard linebreaks. Cleanup trailing whitespace in docs Add `force` option Update QUnit to latest; cleanup QUnit markup Add new events for fail conditions, so that reporters can still report on the test Bump v0.2.2 ... Conflicts: CHANGELOG Gruntfile.js README.md package.json phantomjs/bridge.js tasks/qunit.js
…:gruntjs/grunt-contrib-qunit into merge-upstream * github.com:gruntjs/grunt-contrib-qunit: (26 commits) 0.4.0 Update grunt-lib-phantomjs to v0.5.0. Explicitly set files to publish to npm. Ref gruntjs/gruntjs.com#65 Update qunit-overview.md, include CentOS dependencies. Closes asciidiscogh-49 0.3.0 Fixes asciidiscoGH-47. Update to latest phantom dependency. Remove Gruntfile.js as main in package.json removing confusing error message Propagate error.onError events from Phantom. Closes asciidiscoGH-11. Update README Update readme to document PhantomJS OS dependencies. Fixes asciidisco#43 Revert "Cleanup trailing whitespace in docs". Necessary for hard linebreaks. Cleanup trailing whitespace in docs Add `force` option Update QUnit to latest; cleanup QUnit markup Add new events for fail conditions, so that reporters can still report on the test Bump v0.2.2 Remove broken link in docs Update devDeps Update copyright ... Conflicts: README.md package.json phantomjs/bridge.js tasks/qunit.js
I think we should configure the
.npmignore
files within the contrib plugins to only include relevant files to run the task. No docs, tests or Gruntfile.js. That way we can alleviate a little bit of the time and space it takes to install the tasks.Any objections or something I'm missing by doing this?
/cc @cowboy @vladikoff @sindresorhus @jsoverson
The text was updated successfully, but these errors were encountered: