Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the report option #259

Closed
wants to merge 1 commit into from
Closed

Fix the report option #259

wants to merge 1 commit into from

Conversation

jpillora
Copy link

Fix the report option by using grunt.log instead of grunt.verbose

I upgraded from 0.2.x and there uglify had one grunt.log print:

File dist/1/xhook.min.js created: 13.23 kB → 5.82 kB → 2.52 kB (gzip)

It seems to only grunt.verbose print now. Maybe this was on purpose?

Use `grunt.log` so the `report` option displays.
@jpillora jpillora changed the title Use grunt.log so the report option displays Fix the report option Sep 15, 2014
@UltCombo
Copy link
Contributor

Related #254 #249 #229 #75

@jpillora
Copy link
Author

I seeeee, quite the contentious issue. We don't need a 5th issue about this so I'll close. My vote is for at least one success print, or an option to enable this grunt.log, or for the report option to enable this grunt.log.

@jpillora jpillora closed this Sep 15, 2014
@commadelimited
Copy link

I know this issue is closed, but I'll chime in here. I'm writing a chapter about Grunt for a book I'm co-authoring. The docs have this to say about the report option:

report

Choices: 'min', 'gzip'
Default: 'min'

Either report only minification result or report minification and gzip results. This is useful to see exactly how well uglifyjs is performing but using 'gzip' will make the task take 5-10x longer to complete. Example output.

Nowhere in the docs does it indicate that -v is required to display the report. The docs should either be updated to reflect this requirement, or allow the report to display without verbose mode (my preference). I don't want ALL of the output, just the bits I'm explicitly requesting as per the documentation.

@STRML
Copy link

STRML commented Oct 21, 2014

+1 for this, doesn't make sense to have the option if we can't see the output anyway.

@zachleat
Copy link

zachleat commented Nov 3, 2014

+1 for non-verbose report output. The default report should be empty, with non-empty values for report showing non-verbose output.

zachleat added a commit to filamentgroup/shoestring that referenced this pull request Nov 3, 2014
…tes, this removes the gzip reported size from the uglifyjs task (which wasn’t accurate anyway). To show the gzip minified size, use `grunt -v` Related: gruntjs/grunt-contrib-uglify#259
@leandono
Copy link

+1 for the @zachleat solution, the option needs 3 values: false (default), min or gzip.

@zachleat
Copy link

For future visitors, I believe the discussion for this issue is currently taking place at #254.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants