Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Puppeteer and add Windows testing on Travis #155

Merged
merged 2 commits into from
Dec 29, 2018

Conversation

Krinkle
Copy link
Contributor

@Krinkle Krinkle commented Dec 28, 2018

Fixes #154.

/cc @XhmikosR

@XhmikosR
Copy link
Member

@vladikoff I don't see why you merged this when AppVeyor is also present.

@Krinkle Krinkle deleted the wintest branch December 29, 2018 19:18
@vladikoff
Copy link
Member

@XhmikosR we can give it a try and remove it later, no big deal.

@Krinkle
Copy link
Contributor Author

Krinkle commented Dec 30, 2018

@XhmikosR AppVeyor is great, but I think some users of grunt-contrib-qunit will prefer to use only one CI system and might pick Travis for testing Windows if they are already familiar with that.

Per #154, the problem with Chrome only affected Windows Server 2016 (used at Travis), it did not affect AppVeyor (which currently uses Windows Server 2012, I think).

The AppVeyor tests for grunt-contrib-qunit, as well as the AppVeyor tests for qunitjs/qunit were passing. The easiest way to ensure that grunt-contrib-qunit stays green for Windows on Travis, was to add a test for exactly that :)

If AppVeyor can be configured to test both Windows versions, then that would also cover it. But, I do not know AppVeyor well enough to know how to do that.

@XhmikosR
Copy link
Member

XhmikosR commented Dec 30, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants