Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path implementation changed in node v6 to assert inputs as strings #271

Merged
merged 1 commit into from
Sep 1, 2016
Merged

Conversation

hthief
Copy link
Contributor

@hthief hthief commented Jun 17, 2016

Seems to keep the task running the same as before, in the issue I was having, when an input was a non-existent file and instead of creating an empty .css it broke the execution.

Fixes #270.

@PavelVanecek
Copy link

I confirm this fixes #270 and I would also like this merged so I can use node 6.

@XhmikosR
Copy link
Member

/CC @shama @vladikoff

@Reedyseth
Copy link

Just to confirm,

This change also made the compilation worked for me, this fixes yeoman/generator-angular#1320

@XhmikosR
Copy link
Member

I wonder if this affects other contrib plugins too.

@gabzim
Copy link

gabzim commented Aug 9, 2016

will this ever get merged?

@XhmikosR
Copy link
Member

XhmikosR commented Aug 9, 2016

I'll take a closer look later. Still wonder if it affects other contrib
plug-ins though.

On Aug 10, 2016 12:24 AM, "Gabriel Zimmermann" [email protected]
wrote:

will this ever get merged!


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#271 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAVVtQXkovfcF9aGoFUwC9CbG6lkoKHtks5qePASgaJpZM4I4Q53
.

@tamitutor
Copy link

+1 (merge)

@phil-hudson
Copy link

Please merge this and release!

@ZeliosAriex
Copy link

+1 Merge 😄

@vladikoff vladikoff merged commit f806e2d into gruntjs:master Sep 1, 2016
@phil-hudson
Copy link

WOOOOOOOO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants