Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drag and Drop Image to decode #26

Closed
monsdroid opened this issue Mar 24, 2018 · 3 comments
Closed

Drag and Drop Image to decode #26

monsdroid opened this issue Mar 24, 2018 · 3 comments

Comments

@monsdroid
Copy link

In some situations its not possible to access the camera device (e.g. no camera present/not supportet api)
In such cases it would be nice to be able to drag and drop or file choose an image to feed to the decoder which is already there.
The Panel could be a AspecRatio container derived from the video constraints or extra parameters to the component. AR settings should superseed height/width these days.

Best regards and thanks for the great work so far! Using your component in cooking-cloud.com App. so far no bugs/error reports from testing people
gruhn added a commit that referenced this issue Apr 6, 2018
@gruhn
Allow scanning via image file drag-and-drop
d56dcbd 
At any time users with or without an active camera can drop image files
anywhere in the area of the component to scan them for QR codes.

See #26
@gruhn gruhn mentioned this issue Apr 6, 2018
Merged
gruhn added a commit that referenced this issue Aug 10, 2018
@gruhn
feat: scanning via image file drag-and-drop
aca95ce 
Allow users to scan image files or website embedded images.
Especialls useful as fallback for devices without installed
cameras.

Introducing `detect` event for deeper insights of scanning
results.

Close #26 #46
@gruhn gruhn closed this as completed in cf42788 Aug 16, 2018
@gruhn
Copy link
Owner

gruhn commented Aug 16, 2018

Sorry, it took so long. I was totally overthinking how to implement this.

@monsdroid
Copy link
Author

Thanks for taking the Ratio into Account!

@gruhn
Copy link
Owner

gruhn commented Aug 22, 2018

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@monsdroid @gruhn