Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser field in package.json #212

Closed
chaitanyapotti opened this issue Dec 7, 2020 · 1 comment · May be fixed by katnova/2FAuth#728, katnova/2FAuth#733, katnova/2FAuth#738, katnova/2FAuth#743 or katnova/2FAuth#747

Comments

@chaitanyapotti
Copy link

chaitanyapotti commented Dec 7, 2020

Describe the bug
Please don't specify browser field in package.json.
it causes webpack to use umd build to bundle which doesn't de-deduplicate dependencies and causes code bloat.

if you want to specify browser field, Please use some configuration like this here
(Assuming you have an esm build. If not, not specifying browser field is better)

Reasoning

As seen here, cjs build should be used by bundlers and not umd

gruhn added a commit that referenced this issue Dec 11, 2020
@gruhn
Copy link
Owner

gruhn commented Dec 11, 2020

thanks for pointing that out. Field is removed in next release.

@gruhn gruhn closed this as completed Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment