Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed cython client-side call tracking #7275

Merged
merged 1 commit into from
Jul 8, 2016

Conversation

kpayson64
Copy link
Contributor

This ensures sync calls get cancelled after
a keyboard interrupt, as well as all calls
getting destroyed before grpc_shutdown()

This solves #7121 and #7090

It is the smaller version of #7157 with only the required changes.

@@ -37,13 +37,19 @@ cdef class Call:
self.c_call = NULL
self.references = []

def start_batch(self, operations, tag):
def start_batch(self, operations, tag, client_side=False):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Break this up into _start_batch(self, operations, tag, retain_self), start_client_batch(self, operations, tag), and start_server_batch(self, operations, tag).

This ensures sync calls get cancelled after
a keyboard interrupt, as well as all calls
getting destroyed before grpc_shutdown()
@kpayson64
Copy link
Contributor Author

Addressed comments.

@nathanielmanistaatgoogle
Copy link
Member

Luhguhtum; thank you for the smaller change.

@soltanmm
Copy link
Contributor

soltanmm commented Jul 8, 2016

LGTM (not that you need it :-P )

@kpayson64
Copy link
Contributor Author

Test Failures are unrelated

@kpayson64 kpayson64 merged commit f5d5ad8 into grpc:master Jul 8, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants