Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower six version requirements #5284

Closed
wants to merge 1 commit into from

Conversation

soltanmm
Copy link
Contributor

cc @jtattermusch
Fixes #5247.

@jtattermusch
Copy link
Contributor

@soltanmm , can you please incorporate changes from https://github.com/grpc/grpc/pull/5176/files (after verifying they are not breaking anything)?

@nathanielmanistaatgoogle
Copy link
Member

Looks good; merge at your leisure.

@soltanmm
Copy link
Contributor Author

Huh. It turns out that because pip eagerly grabs higher version numbers on our dependencies (like sphinx, enum34, and futures), our transitive dependencies almost always end up requiring six>=1.9, and will almost always end up vomiting strange version conflict error messages to our users. Furthermore, the only way we'd get any benefit out of a PR like this one is if we decrease the required version to 1.8 or below (for various Ubuntu flavors).

I don't think this is a good idea anymore.

@soltanmm soltanmm closed this Feb 17, 2016
@soltanmm soltanmm deleted the less-than-six branch March 17, 2016 17:40
@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants