[LB policy API] change metadata mutation API to handle discarded picks #36968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdroth
added
the
release notes: no
grpc-checks
bot
added
per-call-memory/increase
per-channel-memory/neutral
per-call-memory/neutral
and removed
per-call-memory/increase
labels
grpc-checks
bot
added
per-call-memory/increase
and removed
per-call-memory/neutral
labels
ctiller
approved these changes
Jun 20, 2024
grpc-checks
bot
added
per-call-memory/decrease
and removed
per-call-memory/increase
labels
alto-ruby
added a commit
to alto-ruby/grpc
that referenced
this pull request
Jul 11, 2024
…ded picks (grpc#36968)" This reverts commit 34a0318.
sourabhsinghs
pushed a commit
to sourabhsinghs/grpc
that referenced
this pull request
Sep 26, 2024
grpc#36968) Previously, metadata mutations were made by the picker directly, which meant that they would be applied even if the channel winds up discarding the pick due to the returned subchannel having been disconnected by the time the pick result is returned. This changes the API such that pickers return metadata mutations along with the pick result, so that the mutations won't get applied unless the pick result is actually used. Closes grpc#36968 COPYBARA_INTEGRATE_REVIEW=grpc#36968 from markdroth:lb_metadata_api 2765da6 PiperOrigin-RevId: 645451869
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
Nov 25, 2024
grpc#36968) Previously, metadata mutations were made by the picker directly, which meant that they would be applied even if the channel winds up discarding the pick due to the returned subchannel having been disconnected by the time the pick result is returned. This changes the API such that pickers return metadata mutations along with the pick result, so that the mutations won't get applied unless the pick result is actually used. Closes grpc#36968 COPYBARA_INTEGRATE_REVIEW=grpc#36968 from markdroth:lb_metadata_api 2765da6 PiperOrigin-RevId: 645451869
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, metadata mutations were made by the picker directly, which meant that they would be applied even if the channel winds up discarding the pick due to the returned subchannel having been disconnected by the time the pick result is returned. This changes the API such that pickers return metadata mutations along with the pick result, so that the mutations won't get applied unless the pick result is actually used.