[export] [endpoint] Remove grpc_endpoint_shutdown(). #36195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
added
the
release notes: no
copybara-service
bot
force-pushed
the
test_620101818
branch
from
36f170e to
6e1eeee
Compare
copybara-service
bot
force-pushed
the
test_620101818
branch
2 times, most recently
from
7050202 to
cd9249a
Compare
copybara-service
bot
force-pushed
the
test_620101818
branch
from
cd9249a to
05d3e6c
Compare
grpc-checks
bot
added
per-call-memory/decrease
and removed
per-call-memory/neutral
labels
copybara-service
bot
force-pushed
the
test_620101818
branch
from
05d3e6c to
f4dc0e2
Compare
grpc-checks
bot
added
per-call-memory/increase
and removed
per-call-memory/decrease
labels
copybara-service
bot
force-pushed
the
test_620101818
branch
from
f4dc0e2 to
1162df3
Compare
copybara-service
bot
force-pushed
the
test_620101818
branch
3 times, most recently
from
473a4fb to
aea4c77
Compare
copybara-service
bot
force-pushed
the
test_620101818
branch
2 times, most recently
from
b2721a6 to
b2e86f5
Compare
copybara-service
bot
force-pushed
the
test_620101818
branch
from
3bb70cc to
cdb6ac4
Compare
grpc-checks
bot
added
per-call-memory/neutral
and removed
per-call-memory/increase
labels
copybara-service
bot
force-pushed
the
test_620101818
branch
from
cdb6ac4 to
0a7db66
Compare
copybara-service
bot
force-pushed
the
test_620101818
branch
from
0a7db66 to
00f391b
Compare
copybara-service
bot
force-pushed
the
test_620101818
branch
from
00f391b to
6cf0b4a
Compare
grpc-checks
bot
added
per-call-memory/increase
and removed
per-call-memory/neutral
labels
This gives grpc_endpoint the same destruction-is-shutdown semantic as EventEngine::Endpoint, which will make the migration easier. PiperOrigin-RevId: 639867616
copybara-service
bot
force-pushed
the
test_620101818
branch
from
6cf0b4a to
9b1bb78
Compare
markdroth
added a commit
to markdroth/grpc
that referenced
this pull request
Jun 21, 2024
yashykt
pushed a commit
to yashykt/grpc
that referenced
this pull request
Jul 1, 2024
…rpc#37017) Closes grpc#37017 COPYBARA_INTEGRATE_REVIEW=grpc#37017 from markdroth:iomgr_endpoint_remove_unnecessary_log 1c3d04c PiperOrigin-RevId: 645512854
yashykt
added a commit
that referenced
this pull request
Jul 1, 2024
… (#37131) Backport #37017 to v1.65.x Co-authored-by: Mark D. Roth <[email protected]>
alto-ruby
added a commit
to alto-ruby/grpc
that referenced
this pull request
Jul 10, 2024
…36195 (grpc#37017) (grpc#37131)" This reverts commit cc02070.
alto-ruby
added a commit
to alto-ruby/grpc
that referenced
this pull request
Jul 11, 2024
…36195 (grpc#37017) (grpc#37131)" This reverts commit cc02070.
alto-ruby
added a commit
to alto-ruby/grpc
that referenced
this pull request
Jul 11, 2024
…36195 (grpc#37017)" This reverts commit 0cac2b0.
sourabhsinghs
pushed a commit
to sourabhsinghs/grpc
that referenced
this pull request
Sep 26, 2024
…destroyed (grpc#36921) This fixes a bug introduced in grpc#36195. b/345103652 Closes grpc#36921 COPYBARA_INTEGRATE_REVIEW=grpc#36921 from markdroth:endpoint_chttp2_fix 4f22314 PiperOrigin-RevId: 643159747
sourabhsinghs
pushed a commit
to sourabhsinghs/grpc
that referenced
this pull request
Sep 26, 2024
…rpc#37017) Closes grpc#37017 COPYBARA_INTEGRATE_REVIEW=grpc#37017 from markdroth:iomgr_endpoint_remove_unnecessary_log 1c3d04c PiperOrigin-RevId: 645512854
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
Nov 25, 2024
…destroyed (grpc#36921) This fixes a bug introduced in grpc#36195. b/345103652 Closes grpc#36921 COPYBARA_INTEGRATE_REVIEW=grpc#36921 from markdroth:endpoint_chttp2_fix 4f22314 PiperOrigin-RevId: 643159747
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
Nov 25, 2024
…rpc#37017) Closes grpc#37017 COPYBARA_INTEGRATE_REVIEW=grpc#37017 from markdroth:iomgr_endpoint_remove_unnecessary_log 1c3d04c PiperOrigin-RevId: 645512854
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[export] [endpoint] Remove grpc_endpoint_shutdown().
This gives grpc_endpoint the same destruction-is-shutdown semantic as
EventEngine::Endpoint, which will make the migration easier.
DO NOT SUBMIT. This PR is for testing purposes only. cl/620101818