Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GrpcWebClientBaseOptions types in index.d.ts #998

Merged
merged 1 commit into from
Dec 5, 2020
Merged

Fix GrpcWebClientBaseOptions types in index.d.ts #998

merged 1 commit into from
Dec 5, 2020

Conversation

acalvo
Copy link
Contributor

@acalvo acalvo commented Nov 26, 2020

  • Add unaryInterceptors and streamInterceptors to GrpcWebClientBaseOptions.
  • Make GrpcWebClientBaseOptions optional in the constructor of GrpcWebClientBase.

Update and correct types
0cbe3e4 
* Add `unaryInterceptors` and `streamInterceptors` to `GrpcWebClientBaseOptions`.
* Make `GrpcWebClientBaseOptions` optional in the constructor of `GrpcWebClientBase`.
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 26, 2020 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@stanley-cheung stanley-cheung merged commit 85a76ad into grpc:master Dec 5, 2020
@stanley-cheung stanley-cheung changed the title Update and correct types Fix GrpcWebClientBaseOptions types in index.d.ts Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release notes: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acalvo @stanley-cheung @grpc-kokoro