grpc-web interceptors implementation #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanley-cheung
force-pushed
the
interceptor-impl
branch
3 times, most recently
from
a7765f6
to
ecfd7c4
Compare
stanley-cheung
force-pushed
the
interceptor-impl
branch
from
ecfd7c4
to
1bd0750
Compare
|
Just noted this was merged. That's really great! |
|
@clehene Yes good point. We have added an example using the interceptor here: https://github.com/grpc/grpc-web/blob/master/net/grpc/gateway/examples/echo/commonjs-example/client.js#L36. And we are working on a blog post. But to add to that, we probably should add something to our main README to point out some high level details about interceptors. Yes we should get to that in a bit. |
stanley-cheung
added
release notes: yes
release notes: major
and removed
release notes: yes
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces interceptors for grpc-web according to the design we spec'ed out in #766
author:@Jennnnny