Disable static checkers on generated js files #752
Conversation
|
|
|
@stanley-cheung happy to help! this is a very nice project ❤️ Going deeper into the causes of this issue is because the code relies on |
|
No plan to support ES6 modules for now because protobuf doesn't support ES6 modules yet: https://github.com/protocolbuffers/protobuf/tree/master/js#protocol-buffers---googles-data-interchange-format |
|
I'm still getting 'proto' is not defined (and 'COMPILED') on the protobuf JS file. Do you think the protocolbuffers/protobuf project would add these lines to the protobuf JS file? |
|
I can confirm this has only been added to the |
I was getting TypeScript errors on the generated protobuf file. These directives to turn off ESLint and TypeScript are just comments. They shouldn't affect anyone who is not using ESLint or TypeScript. A similar change was made in the grpc/grpc-web project: grpc/grpc-web#752
I was getting TypeScript errors on the generated protobuf file. These directives to turn off ESLint and TypeScript are just comments. They shouldn't affect anyone who is not using ESLint or TypeScript. A similar change was made in the grpc/grpc-web project: grpc/grpc-web#752
I was getting TypeScript errors on the generated protobuf file. These directives to turn off ESLint and TypeScript are just comments. They shouldn't affect anyone who is not using ESLint or TypeScript. A similar change was made in the grpc/grpc-web project: grpc/grpc-web#752
This will work as a hotfix for #447
I think it could make sense to include it.
Since those are auto generated they never should be edited so it would be ok disable static checkers.
Eslint:
https://eslint.org/docs/2.13.1/user-guide/configuring#disabling-rules-with-inline-comments
Typescript
https://www.typescriptlang.org/docs/handbook/type-checking-javascript-files.html