Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return specific grpc status code on http error #619

Merged
merged 1 commit into from
Aug 23, 2019
Merged

Return specific grpc status code on http error #619

merged 1 commit into from
Aug 23, 2019

Conversation

harmangakhal
Copy link
Contributor

@harmangakhal harmangakhal commented Aug 23, 2019

Resolves the issue I mentioned in #569.

Copy link
Collaborator

@stanley-cheung stanley-cheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contributions.

@stanley-cheung stanley-cheung merged commit 1711674 into grpc:master Aug 23, 2019
@echoma
Copy link

echoma commented Oct 11, 2019

Thanks a lot. really need this fix, user authentication in Istio cant work properly without this fix.

@stanley-cheung When will the grpc-web team make a new release? cant wait :)

loyalpartner pushed a commit to loyalpartner/grpc-web that referenced this pull request Sep 4, 2020
WithEndpointsFunc allows for providing a custom function that provides all
supported endpoints for use when the when `WithCorsForRegisteredEndpoints`
option` is not set to false (i.e. the default state).

WrapHandler takes a http.Handler (such as a http.Mux) and returns a
*WrappedGrpcServer that provides gRPC-Web Compatibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants